Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KE2: Use the right language version #18064

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

igfoo
Copy link
Contributor

@igfoo igfoo commented Nov 21, 2024

With this, if I make the testsuite driver use 1.7, then the test code

sealed interface ReadResult
data class Number(val number: Int) : ReadResult
data class Text(val text: String) : ReadResult
data object EndOfFile : ReadResult

makes the extractor print

=== Diagnostics
--- Diagnostic:
WRONG_MODIFIER_TARGET
ERROR
Modifier 'data' is not applicable to 'standalone object'. Location(startLine=5, startColumn=1, endLine=5, endColumn=4)
--- End diagnostics

With this, if I make the testsuite driver use 1.7, then the test code

sealed interface ReadResult
data class Number(val number: Int) : ReadResult
data class Text(val text: String) : ReadResult
data object EndOfFile : ReadResult

makes the extractor print

=== Diagnostics
--- Diagnostic:
WRONG_MODIFIER_TARGET
ERROR
Modifier 'data' is not applicable to 'standalone object'.
Location(startLine=5, startColumn=1, endLine=5, endColumn=4)
--- End diagnostics
@igfoo igfoo requested a review from a team as a code owner November 21, 2024 16:36
Copy link
Contributor

@tamasvajk tamasvajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible, maybe.

@igfoo igfoo merged commit 05fa332 into github:ke2 Nov 22, 2024
3 checks passed
@igfoo igfoo deleted the igfoo/ke2_lang_ver branch November 22, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants